chore(docs): Update missing default resources for Android #689 #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: This is an almost 1 to 1 copy of 228 that was closed on a technicality
Platforms affected
Only docs
Motivation and Context
Current documentation lacks the default resources for Android.
On Android, you can provide alternative resources for specific device configuration, like current docs provide alternative resources for portrait and landscape orientation. But error will be thrown if a device configuration does not match any specific alternative resources, so you should provide a default (In this case, without port- or land- ) as a fallback.
This change fixes the error reported in #185 and apache/cordova-android#689.
Description
Although orientation is only portrait and landscape as of now, providing default would prevent MissingDefaultResource lint check error and considered as good practice for Android resources configuration.
Note:
You don’t have to provide a default for screen density. The system use whichever resources are the best match.
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)