Add support for setRate on Android. Fix setRate on iOS when seeking. #196
Conversation
BuddyLReno
force-pushed
the
android-set-rate
branch
from
3711b4c to
d8cbfed
Compare
BuddyLReno
force-pushed
the
android-set-rate
branch
4 times, most recently
from
ead0642 to
6a40177
Compare
BuddyLReno
force-pushed
the
android-set-rate
branch
from
6a40177 to
a0ffb0a
Compare
This reverts commit 6686cf0.
|
Why was this reverted? Does it break anything? |
|
Can this be merged please? |
|
@himanshuphirke Nobody reverted anything in this branch, the commits you are seeing were in a fork of this repo: https://github.com/asteasolutions/cordova-plugin-media @bricedupuy Did you review and test this code and can guarantee that it works as expected? |
| } else { | ||
| console.warn('media.setRate method is currently not supported for', cordova.platformId, 'platform.'); | ||
| } | ||
| exec(null, null, "Media", "setRate", [this.id, rate]); |
There was a problem hiding this comment.
This applies to all platforms now (incl. WP, still), however the actual support is only for iOS and Android, as far as I understand.
|
It looks like on Android |
|
|
||
| public void setRate(float speed) { | ||
| // Check for API 23+ | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { |
There was a problem hiding this comment.
If setRate requires API 23, then we should add that as a quirk in the documentation stating that devices with a lower API level will be a no operation.
Platforms affected
What does this PR do?
What testing has been done on this change?
Physical device testing on:
Checklist