Bugfixes - Video Capture for A4.3 && Aync IO #8
Conversation
1) MediaStore.ACTION_VIDEO_CAPTURE Uri return value is null in 4.3 - http://code.google.com/p/android/issues/detail?id=57996 2) Async IO - http://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes
|
Relevant JIRA issue for the async IO problem: And for the ACTION_VIDEO_CAPTURE Uri problem: |
| File fp = webView.getResourceApi().mapUriToFile(data); | ||
| JSONObject obj = new JSONObject(); | ||
| private JSONObject createMediaFile(final Uri data) { | ||
| Future<JSONObject> result = cordova.getThreadPool().submit(new Callable<JSONObject>() |
There was a problem hiding this comment.
createMediaFile is just a helper method, so it shouldn't do any multithreading. Instead, you should put the async logic into the caller. This is done already except for in onActivityResult().
|
Before we can merge your code, I need to confirm that you have signed the Apache Contributor License Agreement? |
|
Async IO has already been fixed on this plugin. Can you please update your patch to work with the latest code? |
|
FYI - CB-5517 was just fixed by pull request #10 (which was essentially the same fix). So, there's just CB-5202 to look at here now. |
|
Hey guys, any word on this? I looked on the ASF page and couldn't find @lubogospod listed anywhere as having signed a CLA. I implemented a stripped down version of this to verify that it fixes the video capture issue on Android 4.3 (nexus devices) since we are getting some requests for this fix. |
|
Closing, I believe these are already fixed. |
|
Sorry, but I'm still not able to record video on 4.3. The plugin works fine on 4.2 and 4.4 but with 4.3 it still needs the null fencing [1] because of this specific 4.3 regression [2]. I can work on putting this specific change in unless you want to submit a new pull request. Also, sorry to bug but did you sign an ICLA? For tiny fixes like null-fencing where there is really only one solution it's probably not a big deal but it's always better to be safe then sorry. [1] https://github.com/apache/cordova-plugin-media-capture/pull/8/files#diff-163d1c08eb8ae99453136db2878340d7R330 |
http://code.google.com/p/android/issues/detail?id=57996
http://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes