Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): improve Localizable.strings & add FR #256

Merged
merged 3 commits into from
Jul 20, 2023
Merged

feat(ios): improve Localizable.strings & add FR #256

merged 3 commits into from
Jul 20, 2023

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Aug 21, 2022

Platforms affected

iOS

Motivation and Context

Review existing Localizable.strings

Description

Update ES Localizable.strings and add FR for french translations.

Testing

.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

erisu
erisu approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu changed the title iOS: Review Localizable.strings and add FR feat(ios): improve Localizable.strings and add FR Aug 22, 2022
@ath0mas ath0mas mentioned this pull request Aug 30, 2022
Merged
@erisu erisu changed the title feat(ios): improve Localizable.strings and add FR feat(ios): improve Localizable.strings & add FR Jul 20, 2023
@erisu erisu merged commit 932e4e3 into apache:master Jul 20, 2023
@ath0mas ath0mas deleted the fr-localizable branch July 20, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ath0mas @erisu