Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep!: bump cordova-plugin-file@^7.0.0 #238

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Apr 12, 2022

Platforms affected

chore

Motivation and Context

File Plugin v7 has recently been released, but it can not be used together with current media-capture plugin because it does not match the range ^6.0.0 set here.

Description

Change range to >=6.0.0.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the change request I suggested on the cordova-plugin-media

plugin.xml Outdated Show resolved Hide resolved
plugin.xml Outdated Show resolved Hide resolved
@ath0mas
Copy link
Contributor Author

ath0mas commented Apr 21, 2022

Similar to the change request I suggested on the cordova-plugin-media

Fine, same answers for this one. Let's see how it goes and get back here then 😉

@ath0mas ath0mas changed the title Change dependency to cordova-plugin-file >=6.0.0 Compatibility with cordova-plugin-file 7 Apr 21, 2022
@ath0mas ath0mas requested a review from erisu April 22, 2022 23:18
@erisu erisu force-pushed the plugin-file-6-7 branch from 9a69c76 to b605a64 Compare April 25, 2022 04:41
@erisu erisu changed the title Compatibility with cordova-plugin-file 7 dep!: bump cordova-plugin-file@^7.0.0 Apr 25, 2022
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased the PR and corrected the version information to match the next major target release.

Everything is good and will be merged in shortly.

@erisu erisu force-pushed the plugin-file-6-7 branch from b605a64 to 49b4783 Compare April 25, 2022 05:27
@erisu
Copy link
Member

erisu commented Apr 25, 2022

Ignore the failing tests, this will be fixed shortly.

The failure is coming from the testing plugin package, not the plugin code itself. It claims that cordova-plugin-media plugin is a dependency while the plugin itself does not require it.

I created a PR: #248, to remove this plugin from the testing package and confirmed that the tests continue to run as expected.

Once I merge in the above PR, I will rebase this PR again so the tests will pass again.

Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking my feedback into consideration and your effort into preparing this PR.

@erisu erisu force-pushed the plugin-file-6-7 branch from 49b4783 to 8c0f812 Compare April 25, 2022 13:32
@erisu erisu merged commit 975e110 into apache:master Apr 25, 2022
@ath0mas ath0mas deleted the plugin-file-6-7 branch April 25, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants