-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dep!: bump cordova-plugin-file@^7.0.0 #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the change request I suggested on the cordova-plugin-media
Fine, same answers for this one. Let's see how it goes and get back here then 😉 |
36f8eef
to
9a69c76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased the PR and corrected the version information to match the next major target release.
Everything is good and will be merged in shortly.
Ignore the failing tests, this will be fixed shortly. The failure is coming from the testing plugin package, not the plugin code itself. It claims that I created a PR: #248, to remove this plugin from the testing package and confirmed that the tests continue to run as expected. Once I merge in the above PR, I will rebase this PR again so the tests will pass again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking my feedback into consideration and your effort into preparing this PR.
Platforms affected
chore
Motivation and Context
File Plugin v7 has recently been released, but it can not be used together with current media-capture plugin because it does not match the range
^6.0.0
set here.Description
Change range to
>=6.0.0
.Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)