Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use single version in cordovaDependencies #212

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

ath0mas
Copy link
Contributor

@ath0mas ath0mas commented Feb 20, 2021

Platforms affected

Package

Motivation and Context

Warn logged while adding plugin with verbose option:

$ cordova plugin add cordova-plugin-media-capture -d
...
Ignoring invalid version in cordova-plugin-media-capture cordovaDependencies: >=1.4.4 (must be a single version <= latest or an upper bound)
...

Description

Using single version 1.4.4 is interpreted as >=1.4.4 so indeed actual value can be simplified.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu changed the title Fix using single version in cordovaDependencies fix: use single version in cordovaDependencies Jul 20, 2023
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 0f07bef into apache:master Jul 20, 2023
@ath0mas ath0mas deleted the fix/cordovadep-version branch July 20, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants