Android: Remove unknown permission android.permission.RECORD_VIDEO #200
Conversation
ath0mas
force-pushed
the
fix/record-video-permission
branch
from
74f2a4f to
3f34981
Compare
ath0mas
changed the title
|
Looks good to me. The plugin uses intents, not the camera apis directly so the camera permission is not required. |
|
Is this going to be merged? It's been 3 1/2 months for a tiny change that is causing apps to be flagged by Android.. |
|
@vesper8 waiting for this PR among few others contributed but not merged either :/ (for now I am successfully using published fork only meant to pre-release those missing fixes) |
|
@ath0mas thanks for mentioning your fork. I would like to use it also but I get an error when trying to add it: Any idea why this is happening? |
|
I'll give out a last call. If I don't see a rejection in the next 48 hours or so, I'll merge. |
|
@breautek thank you! Also.. it's not entirely clear if you need to tag a new release in order for us to be able to get the latest changes after you've merged it in? I would assume that a new release/tag is needed otherwise we'll just be getting 3.0.3 which is dated from June 2019 |
|
According to this, all permissions should be removed, not just RECORD_VIDEO, but that can be done in a separate PR |
|
Since I got my green checks I'll go ahead and merge now. |
I'm not sure when a release to NPM will be made. Personally I might be busy due to other upcoming projects. You can (however I must say it should be for testing purposes only...) install from git. I'd recommend using the commit hash so that you can ensure a consistent "version" of what you're installing. The command below should work, although untested. Don't forget to remove your current plugin install. Thank you @ath0mas for your effort in preparing this PR. |
|
Thanks for the merge 👍 |
@vesper8 same here, version with pre-release suffix seams not fine for cordova-lib. |
* origin-apache/master: (91 commits) ci(ios): update workflow w/ iOS 15 (apache#231) ci: add action-badge (apache#230) ci: remove travis & appveyor (apache#229) ci: add gh-actions workflows (apache#228) fix(android): remove unknown permission android.permission.RECORD_VIDEO (apache#200) ci: add node-14.x to workflow (apache#203) chore: clean up package.json (apache#193) ci(travis): update osx xcode image (apache#189) breaking(ios): remove code warnings (apache#177) ci(travis): updates Android API level (apache#188) chore: adds package-lock file (apache#180) refactor(eslint): use cordova-eslint /w fix (apache#179) chore(npm): use short notation in package.json (apache#178) chore(asf): update git notification settings Update CONTRIBUTING.md ci: updates Node.js versions (apache#165) chore(npm): improve ignore list (apache#164) Small javadoc fix (apache#161) ci(travis): upgrade to node 8 chore(release): 3.0.4-dev ...
Platforms affected
Android
Motivation and Context
Permission
android.permission.RECORD_VIDEOdoes not exist.Fix #199
Description
Also described as a made-up permission in this SO post.
Android guides on audio and video recording with MediaRecorder only refer to RECORD_AUDIO and some other permissions but never to this one.
Testing
build
Checklist
(platform)if this change only applies to one platform (e.g.(android))