Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): UI sizing of the audio capture controller according to parent view size #185

Conversation

BardRedStar
Copy link
Contributor

Fixed UI sizing for audio capture controller according to parent view size

Platforms affected

iOS

Motivation and Context

Audio capture controller's view looks different for iPhones and iPads and crops according to the device size.
1
2

Description

I changed the size calculation for the audio capture controller's layout. Now the UI looks good on all devices.
3

Testing

I didn’t find any tests for this plugin.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@ath0mas
Copy link
Contributor

ath0mas commented Feb 9, 2021

Fixes #176 and #208

@ath0mas
Copy link
Contributor

ath0mas commented Feb 16, 2021

@timbru31 see how this PR and few others can be integrated, with resolved conflicts, in the fork I have been successfully using for months now

@sdemir60
Copy link

@timbru31 see how this PR and few others can be integrated, with resolved conflicts, in the fork I have been successfully using for months now

Thank you very much for your support.

I installed the plugin from the fork you created.

These fixes are not available in the main repository?

@ath0mas
Copy link
Contributor

ath0mas commented Jun 3, 2021

@sdemir60 Yes, as of today nearly all the fixes I merged in my fork are still open PRs on the main repository

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and confirmed that the code resolves the UI sizing.

Could you rebased this branch with master and resolve the conflicts?

We should be able to get this PR merged in.

@erisu erisu changed the title iOS: Fixed UI sizing for audio capture controller according to parent view size fix(ios): UI sizing of the audio capture controller according to parent view size Aug 7, 2023
@ath0mas
Copy link
Contributor

ath0mas commented Aug 7, 2023

I can help on this rebase if it has to be done quickly this week ; tell me @BardRedStar @erisu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants