Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): issues 285 #286

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kumo01GitHub
Copy link

Platforms affected

android

Motivation and Context

workaround fix #285

According to W3C, request a position and acquire a position should processing in parallel. In result, timeout timer starts before application gets permission request result.

Description

Setup timer in JavaScript for Android. At first, I referenced iOS implementation but createTimeout didn't work as I thought. (When timeout, timeoutTimer in getCurrentPosition didn't be set null. This caused success callback and return current position after timeout error.) So, there is some deference.

Testing

Tested with simulator and sample application.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@kumo01GitHub kumo01GitHub changed the title Fix/issues 285 fix(android): issues 285 Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout deference between iOS and Android
1 participant