CB-13916(android): Suppress deprecation warnings #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
changed the title
jcesarmobile
requested changes
Dec 15, 2019
There was a problem hiding this comment.
I think the only deprecated class is ProgressDialog, not the others.
I don't think we should hide the warnings, but to remove them.
If that means killing the progressStart/progressStop I'm ok with that, since they are not documented (but we should do a major release anyway)
There was a jira issue for the deprecated warnings, so I've changed the title:
https://issues.apache.org/jira/browse/CB-13916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some changes needed to suppress ugly deprecation warnings when building on Android.
Note that with these changes, old
android.annotationpackage is no longer used. This is desired since a number ofandroid.annotationpackages should be considered obsolete forandroidx(apache/cordova-android#565; apache/cordova#69).