CB-11242 - Removed platform-specific code for platforms w/ PlatformApi implemented #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 81.9% 79.63% -2.27%
==========================================
Files 68 60 -8
Lines 5498 4272 -1226
Branches 1090 890 -200
==========================================
- Hits 4503 3402 -1101
+ Misses 995 870 -125
Continue to review full report at Codecov.
|
stevengill
suggested changes
Mar 25, 2017
| @@ -0,0 +1,14 @@ | |||
| # Non-project-specific build files: | |||
There was a problem hiding this comment.
don't think you need this file
| @@ -11,15 +9,12 @@ | |||
| "osx": { | |||
| "hostos": ["darwin"], | |||
| "parser_file": "../cordova/metadata/osx_parser", | |||
| "handler_file": "../plugman/platforms/ios", | |||
There was a problem hiding this comment.
hmm, this might be an issue. OSX uses ios handler file. Maybe make a copy of ../plugman/platforms/ios and rename it to ../plugman/platforms/osx and update this file to use the copy
audreyso
force-pushed
the
CB-11242
branch
3 times, most recently
from
9f8e37e to
08513f0
Compare
…roid and added cordova dir to android test in fixtures dir and removed uninstall android files because causing errors
…ms.spec to use browser instead of android & android_uninstall not needed
audreyso
force-pushed
the
CB-11242
branch
4 times, most recently
from
aa734c2 to
379b61b
Compare
…lude all needed files
chauthai
pushed a commit
to mobilexag/cordova-hot-code-push
that referenced
this pull request
May 8, 2017
Due to this [issue](apache/cordova-lib#526) there is no `cordova-lib/src/plugman/platforms/ios` anymore. The fix is taken from this [issue](nordnet#295)
vimalb
pushed a commit
to vimalb/cordova-hot-code-push
that referenced
this pull request
Oct 10, 2017
Due to this [issue](apache/cordova-lib#526) there is no `cordova-lib/src/plugman/platforms/ios` anymore. The fix is taken from this [issue](nordnet#295)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
Removed platform-specific code for platforms w/ PlatformApi implemented (ios, android, windows).
Android testing files also updated.
What testing has been done on this change?
Checklist