-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: readme improvements (cleaup, xcode debugging, etc) #1133
Conversation
I just applied the same changes suggested and merged by @erisu in linked PR for cdv-android. Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all, I think these are good improvements. I Just have a couple of nit picks.
Codecov Report
@@ Coverage Diff @@
## master #1133 +/- ##
=======================================
Coverage 74.86% 74.86%
=======================================
Files 13 13
Lines 1723 1723
=======================================
Hits 1290 1290
Misses 433 433 Continue to review full report at Codecov.
|
As for @NiklasMerz comment
IMO, if you want to add this to the README, only suggest opening the If my memory is correct, there were issues in the past when opening |
@erisu I agree. I have used both with no issues so far but we should only recommend the workspace. |
README.md
Outdated
@@ -7,9 +7,9 @@ | |||
# to you under the Apache License, Version 2.0 (the | |||
# "License"); you may not use this file except in compliance | |||
# with the License. You may obtain a copy of the License at | |||
# | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# | |
# |
Revert
Co-authored-by: Niklas Merz <NiklasMerz@gmx.net>
Co-authored-by: Niklas Merz <NiklasMerz@gmx.net> Co-authored-by: エリス <erisu@users.noreply.github.com>
Platforms affected
iOS
Motivation and Context
Reviewing Readme between cordova-ios and cordova-android.
Description
Fix typo and add "Debugging in Xcode".
(also see similar PR for cordova-android apache/cordova-android#1308)
Testing
.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)