-
Notifications
You must be signed in to change notification settings - Fork 984
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CB-7606 - handleOpenURL not working correctly on cold start (handler …
…not evaluated yet) and warm start
- Loading branch information
Showing
5 changed files
with
114 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /* | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| */ | ||
|
|
||
| #import "CDVPlugin.h" | ||
|
|
||
| @interface CDVHandleOpenURL : CDVPlugin | ||
|
|
||
| @property (nonatomic, strong) NSURL* url; | ||
| @property (nonatomic, assign) BOOL pageLoaded; | ||
|
|
||
| @end | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| */ | ||
|
|
||
| #import "CDVHandleOpenURL.h" | ||
| #import "CDV.h" | ||
|
|
||
| @implementation CDVHandleOpenURL | ||
|
|
||
| - (void)pluginInitialize | ||
| { | ||
| [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(applicationLaunchedWithUrl:) name:CDVPluginHandleOpenURLNotification object:nil]; | ||
| [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(applicationPageDidLoad:) name:CDVPageDidLoadNotification object:nil]; | ||
| } | ||
|
|
||
| - (void)applicationLaunchedWithUrl:(NSNotification*)notification | ||
| { | ||
| NSURL *url = [notification object]; | ||
| self.url = url; | ||
|
|
||
| // warm-start handler | ||
| if (self.pageLoaded) { | ||
| [self processOpenUrl:self.url pageLoaded:YES]; | ||
| self.url = nil; | ||
| } | ||
| } | ||
|
|
||
| - (void)applicationPageDidLoad:(NSNotification*)notification | ||
| { | ||
| // cold-start handler | ||
|
|
||
| self.pageLoaded = YES; | ||
|
|
||
| if (self.url) { | ||
| [self processOpenUrl:self.url pageLoaded:YES]; | ||
| self.url = nil; | ||
| } | ||
| } | ||
|
|
||
| - (void)processOpenUrl:(NSURL*)url pageLoaded:(BOOL)pageLoaded | ||
| { | ||
| if (!pageLoaded) { | ||
| // query the webview for readystate | ||
| NSString* readyState = [self.webView stringByEvaluatingJavaScriptFromString:@"document.readyState"]; | ||
| pageLoaded = [readyState isEqualToString:@"loaded"] || [readyState isEqualToString:@"complete"]; | ||
| } | ||
|
|
||
| if (pageLoaded) { | ||
| // calls into javascript global function 'handleOpenURL' | ||
| NSString* jsString = [NSString stringWithFormat:@"document.addEventListener('deviceready',function(){if (typeof handleOpenURL === 'function') { handleOpenURL(\"%@\");}});", url]; | ||
| [self.webView stringByEvaluatingJavaScriptFromString:jsString]; | ||
| } else { | ||
| // save for when page has loaded | ||
| self.url = url; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| @end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters