Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove trailing spaces from project template #997

Merged

Conversation

brodycj
Copy link

@brodycj brodycj commented Jun 10, 2020

Platforms affected

Android

Motivation and Context

see title

Description

  • remove trailing spaces from bin/templates/project/AndroidManifest.xml
  • remove trailing spaces from bin/templates/project/assets/www/css/index.css

open question: I was wondering if we should really keep www assets committed in cordova-android or any other repos? Shouldn't we just use the www assets from the app-hello-world template?

Testing

see below

Checklist

  • I've run the tests to see all new and existing tests pass - check GitHub CI
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #997 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #997   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files          21       21           
  Lines        1866     1866           
=======================================
  Hits         1271     1271           
  Misses        595      595           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dead4b4...13db3cf. Read the comment docs.

@dpogue
Copy link
Member

dpogue commented Jun 10, 2020

open question: I was wondering if we should really keep www assets committed in cordova-android or any other repos? Shouldn't we just use the www assets from the app-hello-world template?

I believe these are required for the platform-centred workflow where users download cordova-android and then use the bin/create script to create new projects as opposed to using the cordova CLI.

@brodycj
Copy link
Author

brodycj commented Jun 10, 2020

I believe these are required for the platform-centred workflow

Makes sense to me. I wonder if we should consider doing anything to keep these in sync, like we do with cordova.js.

I definitely recall discussions of removing platform-centered workflow. I would personally favor keeping it whenever possible, don't really like the added support burden though. I wonder if we could find some way to automate this.

@brodycj brodycj marked this pull request as ready for review June 10, 2020 02:35
@brodycj brodycj merged commit 1b6319e into apache:master Jun 10, 2020
@brodycj brodycj deleted the remove-trailing-spaces-from-project-template branch June 10, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants