[major] feat: Gradle 6.5 & Android Gradle plugin 4.0.0 updates

[brodycj]

Platforms affected

Android

Motivation and Context

• Android Studio 4.0 recommended updating to multiple build.gradle
• Gradle 6.1.1 update seems to be required to build with Android Gradle plugin 4.0.0 update, may as well go with Gradle 6.5 update

I think it would be ideal if we could make this update before shipping the new major 9.0.0 release.

Description

• update to use Gradle 6.5
• update the following build.gradle files as suggested by Android Studio 4.0:
  • bin/templates/project/app/build.gradle
  • bin/templates/project/build.gradle
  • framework/build.gradle

Note that this proposal would effectively overwrite some or all changes from the following PRs:

• breaking: Bump android gradle plugin to 3.6.0 #962
• [MAJOR] Gradle upgrade from 4.10.3 to 6.x #792

/cc @erisu @breautek

Testing

• tested with command-line build from Cordova CLI
• tested with Android Studio 4.0

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[codecov-commenter]

Codecov Report

Merging #988 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #988   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files          21       21           
  Lines        1866     1866           
=======================================
  Hits         1271     1271           
  Misses        595      595           

Impacted Files	Coverage Δ
...n/templates/cordova/lib/builders/ProjectBuilder.js	73.21% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287bfcb...766a09c. Read the comment docs.

[breautek]

Should also update the two gradle wrapper files in the tests at:

https://github.com/apache/cordova-android/blob/master/test/android/wrapper.gradle
https://github.com/apache/cordova-android/blob/master/test/androidx/wrapper.gradle

Also their respective build.gradle files for the android gradle plugin, which currently is still at version 3.6.0

[mosabab]

Should also update the two gradle wrapper files in the tests at:

https://github.com/apache/cordova-android/blob/master/test/android/wrapper.gradle
https://github.com/apache/cordova-android/blob/master/test/androidx/wrapper.gradle

Also their respective build.gradle files for the android gradle plugin, which currently is still at version 3.6.0

@breautek
I build my android release version with cordova:
cordova build android --release

Could you please check this message when I build my app?

Does this message normal ?
Because I can see some warnings for Gradle .....etc
The build success but i need to know if this normal or there may be some issues?

Please note that the following is insatlled in my pc:

• The latest cordova cli v 9.0.0
• Gradle v6.5
• Android Studio Latest Version v4.0 with with sdk 29.
• cordova-android.git#master version.
• JDK 8 (jdk1.8.0_251)
• Node.js v12.18.0

---

Thanks
Regards

[breautek]

Yes, that's normal. Gradle always appear to have deprecation warnings, but if you use gradle directly with the stacktrace flag, then you'll see that the faulting code comes from gradle itself.

[mosabab]

Yes, that's normal. Gradle always appear to have deprecation warnings, but if you use gradle directly with the stacktrace flag, then you'll see that the faulting code comes from gradle itself.

Thanks for the clarification

[brodycj]

Should also update the two gradle wrapper files in the tests at:

https://github.com/apache/cordova-android/blob/master/test/android/wrapper.gradle
https://github.com/apache/cordova-android/blob/master/test/androidx/wrapper.gradle

I was actually wondering why keep updating those 2 files while bin/templates/project/wrapper.gradle is kept blank with a comment.

Also their respective build.gradle files for the android gradle plugin, which currently is still at version 3.6.0

The following spec & test build.gradle files also seemed to be out-of-date with respect to the build.gradle files that I had updated.

From a search I did also find bin/templates/project/legacy/build.gradle, wonder if we really want to keep supporting it or not.

I would definitely be happy to update the test Gradle files if needed, just wanted to understand what we should be keeping up-to-date and if there is anything we should not be supporting any longer.

[breautek]

The project/legacy files is from beyond my time, I'm not sure the purpose, but it doesn't appear to be used.

I would definitely be happy to update the test Gradle files if needed, just wanted to understand what we should be keeping up-to-date and if there is anything we should not be supporting any longer.

The test gradle files should be kept in sync, otherwise the unit tests won't be ran under the same configuration as the runtime when the project is installed.

[brodycj]

I tried copying the updated Gradle files, now leads to a build error. Any ideas?

[brodycj]

I have updated the test Gradle files as requested. There seems to be quite a major difference between the template Gradle files and test Gradle files, and I hope this can be fixed someday.

[breautek]

I think this needs to be updated to 6.5 as well

cordova-android/bin/templates/project/app/build.gradle

Lines 91 to 93 in 287bfcb

	task wrapper(type: Wrapper) {
	gradleVersion = '6.1'
	}

(Eventually I want to create some sort of script that will change all these versions in different places automatically for us...)

[brodycj]

• build is still green
• tested with my cordova-sqlite-storage test app with build & run from Cordova CLI
• tested adding to my cordova-sqlite-storage test app but with build & run from Android Studio 4.0

Merging now, thanks to @breautek for the quick reviews!