breaking: reduce combined response cutoff to 16 MB

[brody4hire]

Updated

Platforms affected

Android

Motivation and Context

see #986 - I think this is needed to avoid crash with JSON memory issue in case of a large number of moderately-sized plugin response messages

Note that this would affect the size of combined responses sent to the JavaScript and not the maximum size of any individual response message.

I hope we can consider this change for cordova-android 9.0.0 which should be coming in the near future.

Description

• reduce the internal payload cutoff constant from 500 MB to 16 MB, as I had proposed in issues with large sets of response payload, even in smaller chunks #986
• rename the payload cutoff constant to COMBINED_RESPONSE_CUTOFF
• update some comments
• cleanup: split if statements into multiple lines

note that this does not completely resolve the issues I raised in #986 due to the ugly warning messages still lurking

Testing

• tested with github:brodybits/cordova-big-android-response-payload-test, with NATIVE_RESPONSE_COUNT changed from 20 to 400, as discussed in issue issues with large sets of response payload, even in smaller chunks #986.
• tested with the spec test app in my cordova-sqlite-storage plugin (sanity test)

Remaining quirks

As I said in #986:

• missing module warning message issue is uncovered, see issues with large sets of response payload, even in smaller chunks #986 for more details
• without background threading, not all response messages make it to the JavaScript side

I hope someone will have time to get to the bottom of these remaining quirks, someday.

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[codecov-commenter]

Codecov Report

Merging #987 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #987   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files          21       21           
  Lines        1866     1866           
=======================================
  Hits         1271     1271           
  Misses        595      595           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305cb2c...edcdf35. Read the comment docs.

[purplecabbage]

lgtm!

[brody4hire]

Thanks to @purplecabbage for the quick review