refactor: simplify doFindLatestInstalledBuildTools

[raphinesse]

Motivation and Context

Just minor code cleanup

Description

• simplify doFindLatestInstalledBuildTools
• remove getAvailableBuildTools
• update com.g00fy2:versioncompare
• use string interpolation for error messages

Testing

npm t

[erisu]

For informational purposes, since Gradle scripts are written in Groovy, using double quotations gives you string interpolation. String literals works 👍

These three lines could be written in one as,

"No usable Android build tools found. Highest installed version is ${highestBuildToolsVersion.getOriginalString()}; minimum version required is ${minBuildToolsVersionString}."

If this way is preferred just because the string is long, I would suggest single quotes so there is no string interpolation.

[raphinesse]

I pushed a commit that uses string interpolation for the error messages while still avoiding line lengths of > 80 characters. What do you think of it?

[erisu]

Even though this line is not touched, same could apply here as an example.

[codecov-io]

Codecov Report

Merging #900 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #900   +/-   ##
=======================================
  Coverage   66.17%   66.17%           
=======================================
  Files          19       19           
  Lines        1839     1839           
=======================================
  Hits         1217     1217           
  Misses        622      622

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a951793...8046808. Read the comment docs.