Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed comment that serves no purpose #863

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

AdriVanHoudt
Copy link
Contributor

Platforms affected

/

Motivation and Context

The comment seemed aggressive and doesn't add any info or seems to have any purpose.

Description

Testing

/

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #863 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files          19       19           
  Lines        1861     1861           
=======================================
  Hits         1233     1233           
  Misses        628      628

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5292781...85cc34f. Read the comment docs.

@timbru31
Copy link
Member

timbru31 commented Nov 4, 2019

Totally, agree. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants