Simplify apkSorter using compare-func package #788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When reviewing #779 I had a hard time understanding what the behavior of
apkSorter
was. I find that is a common issue with complex sort callbacks in JavaScript.IMHO it's often makes for way more readable and less repetitive code to have a
sortBy
style approach. That's what I implemented in this PR forapkSorter
.Description
Implement
apkSorter
in asortBy
style using thecompare-func
module.Testing
I used the existing unit tests. One of them had to be fixed, since it stubbed
fs.statSync
incorrectly (mtime
is aDate
, not a timestamp)