.gitignore add package-lock.json #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
=======================================
Coverage 64.66% 64.66%
=======================================
Files 18 18
Lines 1817 1817
=======================================
Hits 1175 1175
Misses 642 642Continue to review full report at Codecov.
|
erisu
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
Though I still in favor and prefer committing the package-lock.json to GH instead, there is no harm doing this in the meantime.
We can always come back and remove anytime after a decision is made on the open discussion about package-lock.json for all repos.
Also this type of change exists on other various repos of ours.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.