Add missing log to Java version check

[fabiante]

Platforms affected

Every platform

What does this PR do?

Add a log that clarifies the Java validation

What testing has been done on this change?

No testing needed, this just adds a console.log call.

Checklist

• Reported an issue in the JIRA database - Java version check does not print detected version to console #623
• Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• Added automated test coverage as appropriate for this change. - None needed

[codecov-io]

Codecov Report

Merging #624 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   64.66%   64.66%           
=======================================
  Files          18       18           
  Lines        1817     1817           
=======================================
  Hits         1175     1175           
  Misses        642      642

Impacted Files	Coverage Δ
bin/templates/cordova/lib/check_reqs.js	49.74% <0%> (ø)	⬆️
bin/templates/cordova/lib/emulator.js	89.62% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c08f1...33ffdc4. Read the comment docs.

[janpio]

Maybe the check_* function should output this information when it checks the actual values?

[brody4hire]

I liked the first commit (02296b9) better.

I do think it is good to add the statement that the user should check JAVA_HOME, PATH, and ANDROID_HOME settings.

As I said in the comments I am not so happy about not logging the actual environment variable values for the ANDROID_HOME setting. This is information that could really help someone figure out what is not working.

I think some things have been a little mixed up in check_reqs.js. There is module.exports.run that runs a combination of check_java and check_android, which seem to be designed to run independently and are also part of a longer list in module.exports.check_all. I think it would be good to clean this up a bit, but not before the coming Cordova 9 release discussed in apache/cordova#10.

Another thing we need to fix is that we should check ANDROID_SDK_ROOT, as discussed in #617. I think it would be ideal to get that in before Cordova, if possible.

In short, I would really favor keeping the updates simple and keep the existing log statements until we get a chance to make the updates to check ANDROID_SDK_ROOT and cleanup check_reqs.js.

[brody4hire]

I am now convinced that we should not log JAVA_HOME at this point. The follow other things still need to be fixed as I said before:

• need to keep log of ANDROID_HOME path
• error message for JDK 8 check failure needs to be fixed (fix indentation to pass eslint and split into multiple lines)

[brody4hire]

Thanks @fabiante for making the requested changes, merging now.