Fixes and cleanup for Java tests and CI #442
Conversation
raphinesse
force-pushed
the
fix-tests
branch
2 times, most recently
from
73111f3 to
5797228
Compare
raphinesse
changed the title
raphinesse
force-pushed
the
fix-tests
branch
2 times, most recently
from
f22bec6 to
5797228
Compare
|
Travis should be running, I'll open an issue with the ASF INFRA team to get it hooked up again. Please let me know if you notice any other repos where it's stopped picking up new PRs. |
This comment has been minimized.
This comment has been minimized.
|
Looks fine to me, and the tests pass, but @infil00p would know better the gradle requirements and whether this makes sense. |
raphinesse
force-pushed
the
fix-tests
branch
4 times, most recently
from
f050cee to
741ad82
Compare
|
I added my other CI related changes since they depend on the initial ones. Looking forward to reviews. This should also fix the failing build for #445 |
|
Just a gentle reminder: Java Unit tests don't run on CI without this. Would appreciate a review, @infil00p. I can split this up into a few different PRs if preferred.
|
|
I don't think Joe can chime in, he can't devote time to this at this juncture -- we'll just have to pull this in since its a blocker for other PRs, and deal with any incompatibilities as they come. I wish I had more input on this matter, but my Android knowledge (especially gradle issues) is minimal. Thoughts? |
|
Thanks for the info @shazron. I will go ahead, give this a last polish and merge then. I am quite confident that these changes are OK. Furthermore, all of these changes only affect tests. So nothing too dangerous anyway. |
raphinesse
changed the title
This fixes the following issues: * run_java_unit_tests.js always has exit code of 0 thus never failing the npm tests. * "Tests completed successfully" is printed after failing to create the Gradle wrapper and never running the tests. * Gradle errors are printed twice
Before this, Gradle 4.4 was required to build the Gradle wrapper and thus run the Java tests. This was because of all the stuff that had to be configured when running the wrapper task using the build.gradle file. Now we use a config file that only specifies the required Gradle version and nothing else to run the wrapper task. This allows tests to be run with Gradle versions beginning with 2.
This accepts any unaccepted Android SDK licenses in Travis.
* Print Gradle version used for Java tests during build * Allow Java tests to be run from any directory * Simplify Promise wrapping in Java tests runner * Minor improvements
* Use latest Android SDK tools for easier license handling * Reduce installed SDK components to minimum (tools & build tools) * Reduce unnecessary PATH manipulation * Use preinstalled Gradle on Travis CI * Improve Gradle output on Travis CI * Use default image on AppVeyor * Improve formatting & other minor tweaks
Details in commit messages