-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import type definitions from obsolete cordova-plugin-splashscreen #1489
Conversation
Relates to apache/cordova-ios#1255 |
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 21 21
Lines 1748 1748
=======================================
Hits 1263 1263
Misses 485 485 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1d606b0
to
2542612
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8bd4386
to
98d0628
Compare
Hah, I forgot the Anyway, thanks for your contribution, I'm sure the typescript users will be pleased when this is rolled into our next release. |
Platforms affected
Affects TypeScript enabled projects only
Motivation and Context
Type definitions to allow programmatic control of the splashscreen are needed in
cordova-android
now thatcordova-plugin-splashscreen
was obsoleted as part of the Android 12 splash support.Description
Import the current type definitions from
cordova-plugin-splashscreen
and expose them for use within a typescript project.Testing
I've imported this into an existing TypeScript-based application that has
cordova-plugin-splashscreen
removed, and ensured that TypeScript compilation produces no warnings or errorsChecklist
(platform)
if this change only applies to one platform (e.g.(android)
)