Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/allowlist master is merged #1244

Closed
wants to merge 5 commits into from

Conversation

PieterVanPoyer
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Seems like this PR was waiting a rebase or getting the master merged in the feature branche. #1138

I did merge the master in the branche, and submitted a new PR.

All credits to erisu and all info is in the original PR #1138 .

Description

@see #1138

Testing

@see #1138

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #1244 (a5636a8) into master (6d803e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1244   +/-   ##
=======================================
  Coverage   72.00%   72.00%           
=======================================
  Files          21       21           
  Lines        1697     1697           
=======================================
  Hits         1222     1222           
  Misses        475      475           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d803e2...a5636a8. Read the comment docs.

@PieterVanPoyer
Copy link
Contributor Author

Closing, because the original - #1138 - is rebased. Way to go!

@PieterVanPoyer PieterVanPoyer deleted the feat/allowlist-master-is-merged branch July 1, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants