Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow appcompat version to be configurable #1208

Merged
merged 1 commit into from
Apr 18, 2021
Merged

feat: allow appcompat version to be configurable #1208

merged 1 commit into from
Apr 18, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 15, 2021

Motivation and Context

Allow the AndroidX AppCompat library version to be configurable.

Description

Added a config.xml preference to allow users to override the default version at their own risk.

Example Config:

<platform name="android">
    <preference name="AndroidXAppCompatVersion" value="1.3.0-rc01" />
</platform>

Testing

  • npm t
  • cordova build android with no change
  • cordova build android with changes using the example config above that sets the version to 1.3.0-rc01

Checklist

@erisu erisu added this to the 10.0.0 milestone Apr 15, 2021
@erisu erisu requested review from jcesarmobile and breautek April 15, 2021 22:45
@erisu erisu mentioned this pull request Apr 15, 2021
Closed
jcesarmobile
jcesarmobile approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@erisu erisu merged commit 8d40770 into apache:master Apr 18, 2021
@erisu erisu deleted the feat/appcompat-configurable branch April 18, 2021 22:30
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
@erisu @wedgberto
feat: allow appcompat version to be configurable (apache#1208)
d124902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

@timbru31 timbru31 timbru31 approved these changes

@breautek breautek Awaiting requested review from breautek

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@erisu @timbru31 @jcesarmobile