test: fix unit test failures for certain random orders #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
approved these changes
Oct 19, 2020
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Oct 19, 2020
This makes it easier to map test output to files and allows for common setup & teardown of all tests in a file. * test(prepare): wrap in top-level describe block * test(Api): wrap in top-level describe block
raphinesse
force-pushed
the
fix-random-order-unit-tests
branch
2 times, most recently
from
5fdc545 to
2f95944
Compare
Codecov Report
@@ Coverage Diff @@
## master #1094 +/- ##
=======================================
Coverage 69.76% 69.76%
=======================================
Files 20 20
Lines 1806 1806
=======================================
Hits 1260 1260
Misses 546 546 Continue to review full report at Codecov.
|
raphinesse
force-pushed
the
fix-random-order-unit-tests
branch
from
2f95944 to
95af537
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some tests were not order independent
Description
Fixed unit tests to be independent of execution order. See commits.
Testing
Tests pass for various random orders