fix: Concurrent Modification Exception #1091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #924
Platforms affected
Android
Motivation and Context
ConcurrentModificationException occurs when starting app, and sometimes randomly in app usage
Description
Use
Collection.synchronizedMap
and ensure all access is sync by wrap all usage of the collection withsynchronized
keywordTesting
Used for a few months in production now without any issues
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)