Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Concurrent Modification Exception #1091

Merged

Conversation

ebhsgit
Copy link
Contributor

@ebhsgit ebhsgit commented Oct 15, 2020

Fix for #924

Platforms affected

Android

Motivation and Context

ConcurrentModificationException occurs when starting app, and sometimes randomly in app usage

Description

Use Collection.synchronizedMap and ensure all access is sync by wrap all usage of the collection with synchronized keyword

Testing

Used for a few months in production now without any issues

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #1091 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
+ Coverage   69.71%   69.76%   +0.05%     
==========================================
  Files          20       20              
  Lines        1806     1806              
==========================================
+ Hits         1259     1260       +1     
+ Misses        547      546       -1     
Impacted Files Coverage Δ
bin/templates/cordova/lib/check_reqs.js 59.43% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b56160...48dad95. Read the comment docs.

@breautek breautek closed this Oct 15, 2020
@breautek breautek reopened this Oct 15, 2020
@erisu erisu changed the title Fix for #924 - Concurrent Modification Exception fix: Concurrent Modification Exception Mar 26, 2021
@breautek breautek added this to the 9.1.0 milestone Mar 27, 2021
@breautek breautek requested a review from erisu March 27, 2021 13:46
@breautek
Copy link
Contributor

Thank you for your contribution @ebhsgit

@breautek breautek merged commit 9dcf3eb into apache:master Mar 27, 2021
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Co-authored-by: 8bhsolutions <48874658+8bhsolutions@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants