Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & com.jfrog.bintray.gradle 1.8.5 #1079

Merged
merged 15 commits into from
Oct 6, 2020

Conversation

mosabab
Copy link
Contributor

@mosabab mosabab commented Sep 29, 2020

Platforms affected

Android

Motivation and Context

[To keep Android projects sync with latest Gradle versions and anything related to Gradle]

As Android Gradle plugin release notes https://developer.android.com/studio/releases/gradle-plugin#updating-gradle
Related to Gradle version and Android Gradle Plugin.

Here what the latest versions:

Updates:

  • Gradle version to 6.6.1
  • Android Gradle Plugin version to 4.0.1
  • com.jfrog.bintray.gradle to 1.8.5

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@mosabab
Copy link
Contributor Author

mosabab commented Sep 29, 2020

@breautek
[INVITED TO REVIEW]

@mosabab mosabab changed the title [Frequent Updates] Gradle to v6.6.1 & Android Gradle Plugin to 4.0.1 [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & GradlePluginKotlinVersion 1.4.10 & com.jfrog.bintray.gradle 1.8.5 Oct 5, 2020
@mosabab mosabab requested a review from timbru31 October 5, 2020 12:28
@mosabab mosabab requested a review from breautek October 5, 2020 12:48
@mosabab mosabab changed the title [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & GradlePluginKotlinVersion 1.4.10 & com.jfrog.bintray.gradle 1.8.5 [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & com.jfrog.bintray.gradle 1.8.5 Oct 5, 2020
@mosabab
Copy link
Contributor Author

mosabab commented Oct 5, 2020

@breautek @timbru31
I revert the kotlin as previous to 1.3.50

And keep the gradle version to 6.6.1
And google plugin gradle version to 4.0.1

Could you please review it now

Thanks

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, the changelogs for Gradle 6.6 mention nothing special. I'd like a second look, though.

@breautek
Copy link
Contributor

breautek commented Oct 5, 2020

I'll review later tonight after work.

@breautek
Copy link
Contributor

breautek commented Oct 6, 2020

Looks good to me, merging.

@breautek breautek merged commit 33476b4 into apache:master Oct 6, 2020
ebhsgit pushed a commit to ebhsgit/cordova-android that referenced this pull request Oct 17, 2020
… 1.8.5 (apache#1079)

* Update ProjectBuilder.js

* Update build.gradle

* Update build.gradle

* Update build.gradle

* Update build.gradle

* Update build.gradle

* Update wrapper.gradle

* Update build.gradle

* Update wrapper.gradle

* Update wrapper.gradle

* Update wrapper.gradle

* Update build.gradle

* Update build.gradle

* Update ProjectBuilder.js

* Update ProjectBuilder.js
erisu added a commit that referenced this pull request Apr 8, 2021
… & com.jfrog.bintray.gradle 1.8.5 (#1079)"

This reverts commit 33476b4.
erisu added a commit that referenced this pull request Apr 9, 2021
… & com.jfrog.bintray.gradle 1.8.5 (#1079)" (#1193)

This reverts commit 33476b4.
erisu pushed a commit to erisu/cordova-android that referenced this pull request Apr 10, 2021
…frog.bintray.gradle 1.8.5 (apache#1079)

* Update ProjectBuilder.js
* Update build.gradle
* Update wrapper.gradle
erisu added a commit to erisu/cordova-android that referenced this pull request Apr 10, 2021
* original contribution PR: apache#1079

Co-authored-by: Mosab A <47486787+mosabab@users.noreply.github.com>
erisu added a commit that referenced this pull request Apr 13, 2021
* [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & com.jfrog.bintray.gradle 1.8.5 (#1079)
* Update ProjectBuilder.js
* Update build.gradle
* Update wrapper.gradle
* chore: remove non-gradle wrapper changes
* feat: upgrade gradle@6.8.3 (#1174)

Co-authored-by: Mosab A <47486787+mosabab@users.noreply.github.com>
erisu pushed a commit to erisu/cordova-android that referenced this pull request Apr 13, 2021
…frog.bintray.gradle 1.8.5 (apache#1079)

* Update ProjectBuilder.js
* Update build.gradle
* Update wrapper.gradle
erisu pushed a commit to erisu/cordova-android that referenced this pull request Apr 13, 2021
…frog.bintray.gradle 1.8.5 (apache#1079)

* Update ProjectBuilder.js
* Update build.gradle
* Update wrapper.gradle
erisu pushed a commit to erisu/cordova-android that referenced this pull request Apr 13, 2021
…frog.bintray.gradle 1.8.5 (apache#1079)

* Update ProjectBuilder.js
* Update build.gradle
* Update wrapper.gradle
erisu pushed a commit to erisu/cordova-android that referenced this pull request Apr 13, 2021
…frog.bintray.gradle 1.8.5 (apache#1079)

* Update ProjectBuilder.js
* Update build.gradle
* Update wrapper.gradle
erisu added a commit to erisu/cordova-android that referenced this pull request Apr 13, 2021
* original contribution PR: apache#1079

Co-authored-by: Mosab A <47486787+mosabab@users.noreply.github.com>
erisu added a commit that referenced this pull request Apr 13, 2021
* breaking: upgrade jfrog gradle-bintray-plugin@1.8.5
* original contribution PR: #1079

Co-authored-by: Mosab A <47486787+mosabab@users.noreply.github.com>
ebhsgit pushed a commit to ebhsgit/cordova-android that referenced this pull request May 20, 2021
* [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & com.jfrog.bintray.gradle 1.8.5 (apache#1079)
* Update ProjectBuilder.js
* Update build.gradle
* Update wrapper.gradle
* chore: remove non-gradle wrapper changes
* feat: upgrade gradle@6.8.3 (apache#1174)

Co-authored-by: Mosab A <47486787+mosabab@users.noreply.github.com>
(cherry picked from commit 46d4d92)
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
* [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & com.jfrog.bintray.gradle 1.8.5 (apache#1079)
* Update ProjectBuilder.js
* Update build.gradle
* Update wrapper.gradle
* chore: remove non-gradle wrapper changes
* feat: upgrade gradle@6.8.3 (apache#1174)

Co-authored-by: Mosab A <47486787+mosabab@users.noreply.github.com>
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
* breaking: upgrade jfrog gradle-bintray-plugin@1.8.5
* original contribution PR: apache#1079

Co-authored-by: Mosab A <47486787+mosabab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants