fix: Avoid Crash Report: ConcurrentModificationException #1073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Fix #924
We have a project with 31 plugins installed, in some devices like Huawei p30( or emulator Pixel_3-x86_64 android R) fail starting the app 4 of 10 times.
Showing the ConcurrentModificationException error from the webView.postMessage("splashscreen", "hide"); of the SplashScreen.java
Description
Tracking the #924 thread I found a code to avoid the error using .synchronizedMap. This was not enough the app still crash sometimes.
Then testing using the .forEach instead of the for (CordovaPlugin plugin : this.pluginMap.values()) works. No more ConcurrentModificationException were thrown.
A counterpoint is that .forEach is not available prior android 6 and a check version is needed.
Testing
npm run test
Found a device with launch problems. Start the app a lot of times with this pr code, no ConcurrentModificationException happens again.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)