refactor: Stop suppressing unnecessarily TruelyRandom lints #1046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Fixes #638
Description
The issue is an older issue that pointed out that
SecureRandom
isn't actually secure on android devices pre 4.4. As it's been not supported for such time, it's safe to remove the@suppressLint TruelyRandom
, which will provide us insurance that this method is not modified in an insecure manner in the future.Testing
Ran
npm test
.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)