Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Stop suppressing unnecessarily TruelyRandom lints #1046

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Fixes #638

Description

The issue is an older issue that pointed out that SecureRandom isn't actually secure on android devices pre 4.4. As it's been not supported for such time, it's safe to remove the @suppressLint TruelyRandom, which will provide us insurance that this method is not modified in an insecure manner in the future.

Testing

Ran npm test.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek requested a review from erisu August 11, 2020 00:07
@breautek breautek merged commit 565106f into apache:master Aug 11, 2020
@breautek breautek deleted the stop-suppressing-truely-random branch August 11, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MOBILE TOP 10: M5-INSUFFICIENT CRYPTOGRAPHYMOBILE
2 participants