Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(java): fix, improve and move clean script #1017

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

raphinesse
Copy link
Contributor

This includes the following changes:

  • move this developer-only script to test/ where it conceptually belongs
    • this also prevents it from being distributed with this package
  • fix paths for android and androidx variants
  • make paths relative to the script, not to CWD
  • use removeSync instead of existsSync and existsSync
  • rename npm script to clean:java-unit-tests to clarify scope

This includes the following changes:

- move this developer-only script to test/ where it conceptually belongs
  - this also prevents it from being distributed with this package
- fix paths for `android` and `androidx` variants
- make paths relative to the script, not to CWD
- use `removeSync` instead of `existsSync` and `existsSync`
- rename npm script to `clean:java-unit-tests` to clarify scope
@raphinesse raphinesse requested review from erisu and breautek July 3, 2020 08:16
@raphinesse raphinesse added this to the 9.0.1 milestone Jul 3, 2020
@raphinesse raphinesse merged commit 3204b98 into apache:master Jul 3, 2020
@raphinesse raphinesse deleted the move-and-fix-clean-test branch July 3, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants