NET-642 Fix review requested changes #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xy Settings do not reset proxy settings when re-setting the socket factory create method identical to open _openDataConnection_ for FTPS where proxy is used and ssl socket is created from ssl context
|
@gremi64 ping? |
|
Thanks @garydgregory ! |
|
@garydgregory it works like a charm with the new 3.9.0-SNAPSHOT (master) ! Can't wait for the release in mvn repo ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't modify YaniM #90 PR, so i created mine from his branch.
I tried to update directly from his PR, but i'm not allowed to do so, and since he has not commit anything in the past year... i'm not sure he his active anymore :/