Add support for NetworkACLs for LB on VPC networks #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to upload the image to apache docker repo - before it's merged |
nvazquez
reviewed
Jul 22, 2024
| // create ACL rule | ||
| acl := lb.NetworkACL.NewCreateNetworkACLParams(protocol.CSProtocol()) | ||
| acl.SetAclid(network.Aclid) | ||
| acl.SetAction("Allow") |
There was a problem hiding this comment.
Can you make these values parametrized? (action, cidr, trafficType) - it looks like you currently want them for adding the default ACL allow but it can be reused later if parameters are used
There was a problem hiding this comment.
ideally should not be required. Because, these rules correspond to the LB service created on Kubernetes side. So these would ideally be fixed to action: "allow" and traffictype: "Ingress"
nvazquez
approved these changes
Jul 23, 2024
| // create ACL rule | ||
| acl := lb.NetworkACL.NewCreateNetworkACLParams(protocol.CSProtocol()) | ||
| acl.SetAclid(network.Aclid) | ||
| acl.SetAction("Allow") |
|
@kiranchavala I don't think the issue is wrt to this PR, but in general there's an issue with vmware. |
kiranchavala
approved these changes
Jul 31, 2024
|
LGTM - thanks @Pearl1594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to create and delete Network ACLs as done for Isolated networks (where Firewall rules are added)
On cluster creation:
On deploying nginx
kubectl apply -f <nginx.yaml>
On deleting nginx
kubectl delete -f <nginx.yaml>
