-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section about Domain VPCs #410
base: 4.19
Are you sure you want to change the base?
Conversation
@GaOrtiga can you change the target branch to 4.19. |
b9ace62
to
7058749
Compare
7058749
to
815f947
Compare
@sureshanaparti done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i het it but have a few questions. Maybe in this case aan example could help.
on the **'createNetwork'** API. It is important to note that, in order | ||
for a tier of a different account to be created on the VPC, the account | ||
that creates the tier must have access to both the account that owns the | ||
VPC and the account that owns the tier. The owner of the VPC must also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit confusing. We are talking about a tier that does not exist yet, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we are talking about creating a new tier in an existing VPC.
for a tier of a different account to be created on the VPC, the account | ||
that creates the tier must have access to both the account that owns the | ||
VPC and the account that owns the tier. The owner of the VPC must also | ||
have access to the account that owns the network, however, the opposite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the network here? Is it the same as the tier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they are the same.
Earlier in the document, during the introduction of the components the tiers were introduced as Network tiers
, so I have used both words synonymously to avoid overusing the word tier. However, I can change all mentions of network back to tier if it is affecting the readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GaOrtiga could you please change it to network tiers as in vpc UI and docs we are referring it as network-tier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if it is clear that we are constantly talking about network-tier, I don't think we need an extra example. But please avoid the use of either "network" and possible "tier". We are not writing proza and though prozaic value is never wrong, in this case it may be somewhat confusing indeed.
ping @GaOrtiga can you check/address the outstanding comments. |
@DaanHoogland @kiranchavala @sureshanaparti Thank you for the reviews, I have changed all mentions of Are there any other concerns regarding the text? |
Related PR:
apache/cloudstack#7153
📚 Documentation preview 📚: https://cloudstack-documentation--410.org.readthedocs.build/en/410/