Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section about Domain VPCs #410

Open
wants to merge 2 commits into
base: 4.19
Choose a base branch
from

Conversation

GaOrtiga
Copy link

@GaOrtiga GaOrtiga commented Jun 28, 2024

@sureshanaparti
Copy link
Contributor

@GaOrtiga can you change the target branch to 4.19.

@GaOrtiga GaOrtiga changed the base branch from main to 4.19 June 28, 2024 18:19
@GaOrtiga GaOrtiga force-pushed the add_section_about_Domain_VPCs branch from b9ace62 to 7058749 Compare June 28, 2024 18:20
@GaOrtiga GaOrtiga force-pushed the add_section_about_Domain_VPCs branch from 7058749 to 815f947 Compare June 28, 2024 18:23
@GaOrtiga
Copy link
Author

@sureshanaparti done

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i het it but have a few questions. Maybe in this case aan example could help.

on the **'createNetwork'** API. It is important to note that, in order
for a tier of a different account to be created on the VPC, the account
that creates the tier must have access to both the account that owns the
VPC and the account that owns the tier. The owner of the VPC must also
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing. We are talking about a tier that does not exist yet, do we?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are talking about creating a new tier in an existing VPC.

for a tier of a different account to be created on the VPC, the account
that creates the tier must have access to both the account that owns the
VPC and the account that owns the tier. The owner of the VPC must also
have access to the account that owns the network, however, the opposite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the network here? Is it the same as the tier?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are the same.
Earlier in the document, during the introduction of the components the tiers were introduced as Network tiers, so I have used both words synonymously to avoid overusing the word tier. However, I can change all mentions of network back to tier if it is affecting the readability.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GaOrtiga could you please change it to network tiers as in vpc UI and docs we are referring it as network-tier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if it is clear that we are constantly talking about network-tier, I don't think we need an extra example. But please avoid the use of either "network" and possible "tier". We are not writing proza and though prozaic value is never wrong, in this case it may be somewhat confusing indeed.

@sureshanaparti
Copy link
Contributor

ping @GaOrtiga can you check/address the outstanding comments.

@GaOrtiga
Copy link
Author

@DaanHoogland @kiranchavala @sureshanaparti

Thank you for the reviews, I have changed all mentions of tiers or network to Network Tiers.

Are there any other concerns regarding the text?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants