[CELEBORN-1786] add serviceAccount helm chart #3006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohehuhu
changed the title
turboFei
reviewed
Dec 18, 2024
| name: {{ include "celeborn.serviceAccountName" . }} | ||
| labels: | ||
| {{- include "celeborn.labels" . | nindent 4 }} | ||
| {{- end }} |
turboFei
reviewed
Dec 18, 2024
charts/celeborn/values.yaml
Outdated
| # -- Specifies whether to create a service account for Celeborn | ||
| create: false | ||
| # -- Specifies the name of the service account | ||
| name: default |
There was a problem hiding this comment.
Looks like lint doesn't, by default, allow empty lines at the end of the values.yaml file, so I prefer to adhere to the rule. @turboFei
RexXiong
approved these changes
Dec 18, 2024
|
Merged into main(v0.6.0). |
FMX
changed the title
FMX
pushed a commit
that referenced
this pull request
Dec 18, 2024
<!-- Thanks for sending a pull request! Here are some tips for you: - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'. - Be sure to keep the PR description updated to reflect all changes. - Please write your PR title to summarize what this PR proposes. - If possible, provide a concise example to reproduce the issue for a faster review. --> ### What changes were proposed in this pull request? as title ### Why are the changes needed? Support custom serviceAccount to control what permissions and resources a pod has access to. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? test the template rendering by helm template command line Closes #3006 from zhaohehuhu/dev-1218. Authored-by: zhaohehuhu <luoyedeyi@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
as title
Why are the changes needed?
Support custom serviceAccount to control what permissions and resources a pod has access to.
Does this PR introduce any user-facing change?
No
How was this patch tested?
test the template rendering by helm template command line