Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1489] Update Flink support with authentication support - backport to 0.5 #2603

Closed

Conversation

mridulm
Copy link
Contributor

@mridulm mridulm commented Jul 4, 2024

Backport of #2596 to branch-0.5
Conflicts were in:

  • ApiBaseResourceAuthenticationSuite.scala
  • ApiBaseResourceSuite.scala

Description from #2596:

What changes were proposed in this pull request?

Fix authentication support for Apache Flink.

Why are the changes needed?

Without these changes, Apache Flink applications fail when Celeborn cluster has authentication enabled.

Does this PR introduce any user-facing change?

Fixes authentication support for Apache Flink integration

How was this patch tested?

This is forward port + adaptation of changes we did internally (against 0.4) when testing Apache Flink applications against Celeborn cluster with authentication (and TLS) enabled.
Integration test has been updated to additionally test for Flink applications with authentication enabled in Celeborn cluster.

Merge conflicts in branch 0.5

Fix authentication support for Apache Flink.

Without these changes, Apache Flink applications fail when Celeborn cluster has authentication enabled.

Fixes authentication support for Apache Flink integration

This is forward port + adaptation of changes we did internally (against 0.4) when testing Apache Flink applications against Celeborn cluster with authentication (and TLS) enabled.
Integration test has been updated to additionally test for Flink applications with authentication enabled in Celeborn cluster.

Closes apache#2596 from mridulm/fix-flink-auth-support.

Authored-by: Mridul Muralidharan <mridulatgmail.com>
Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
@mridulm
Copy link
Contributor Author

mridulm commented Jul 4, 2024

+CC @RexXiong

mridulm pushed a commit that referenced this pull request Jul 4, 2024
…ckport to 0.5

Backport of #2596 to branch-0.5
Conflicts were in:
* ApiBaseResourceAuthenticationSuite.scala
* ApiBaseResourceSuite.scala

Description from #2596:

### What changes were proposed in this pull request?
Fix authentication support for Apache Flink.

### Why are the changes needed?
Without these changes, Apache Flink applications fail when Celeborn cluster has authentication enabled.

### Does this PR introduce _any_ user-facing change?

Fixes authentication support for Apache Flink integration

### How was this patch tested?

This is forward port + adaptation of changes we did internally (against 0.4) when testing Apache Flink applications against Celeborn cluster with authentication (and TLS) enabled.
Integration test has been updated to additionally test for Flink applications with authentication enabled in Celeborn cluster.

Closes #2603 from mridulm/fix-flink-auth-support-v0.5.

Authored-by: Mridul Muralidharan <mridulatgmail.com>
Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
@mridulm
Copy link
Contributor Author

mridulm commented Jul 4, 2024

Merged to branch-0.5, thanks @SteNicholas !

@mridulm mridulm closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants