[CELEBORN-1491] introduce flusher working queue size metric #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FMX
changed the title
RexXiong
reviewed
Jul 2, 2024
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/Flusher.scala
Show resolved
Hide resolved
# Conflicts: # assets/grafana/celeborn-dashboard.json
RexXiong
approved these changes
Jul 4, 2024
RexXiong
pushed a commit
that referenced
this pull request
Jul 5, 2024
Add metrics about flusher working queue size. To show if there is an accumulation of flush tasks. NO. GA. Closes #2598 from FMX/b1491. Authored-by: mingji <fengmingxiao.fmx@alibaba-inc.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com> (cherry picked from commit cb6e220) Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
|
Thanks, merge to main(v0.6.0) and branch-0.5(v0.5.1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add metrics about flusher working queue size.
Why are the changes needed?
To show if there is an accumulation of flush tasks.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
GA.