[CELEBORN-1401] Add SSL support for ratis communication #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mridulm
changed the title
mridulm
changed the title
mridulm
commented
May 16, 2024
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HARaftServer.java
Show resolved
Hide resolved
added 2 commits
May 16, 2024 02:44
|
+CC @otterc, @waitinfuture , @FMX , @SteNicholas |
added 2 commits
May 16, 2024 02:55
RexXiong
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When SSL is enabled for master, secure the Ratis communication as well with TLS
Why are the changes needed?
Currently, when TLS is enabled for RPC, Ratis comms still goes in the clear - add support for TLS.
Note that currently this only supports GRPC, and not netty.
Does this PR introduce any user-facing change?
Secures ratis communication when TLS is enabled at master for rpc.
How was this patch tested?
Local tests and additional unit tests added