[CELEBORN-1006][FOLLOWUP] Dependency hadoop-client should exclude hadoop-mapreduce-client dependencies for Hadoop 2 #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oop-mapreduce-client dependencies for Hadoop 2
FMX
approved these changes
May 9, 2024
|
Merged into main(v0.5.0) and branch-0.4(v0.4.1). |
FMX
pushed a commit
that referenced
this pull request
May 9, 2024
…oop-mapreduce-client dependencies for Hadoop 2 ### What changes were proposed in this pull request? Dependency `hadoop-client` should exclude `hadoop-mapreduce-client` dependencies for Hadoop 2. ### Why are the changes needed? `hadoop-mapreduce-client` dependencies of `hadoop-client` are unneccessary. Meanwhile, `hadoop-mapreduce-client` dependencies have dependency `javax.servlet:javax.servlet-api` which causes the compilation error of service module after http server refine in 0.5.0 version. ``` $ mvn clean install -Dhadoop.version=2.10.0 -pl service -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true [INFO] --- scala-maven-plugin:4.7.2:testCompile (scala-test-compile-first) celeborn-service_2.12 --- [INFO] Using incremental compilation using Mixed compile order [INFO] Compiler bridge file: /Users/nicholas/.sbt/1.0/zinc/org.scala-sbt/org.scala-sbt-compiler-bridge_2.12-1.7.1-bin_2.12.18__55.0-1.7.1_20220712T022208.jar [INFO] compiler plugin: BasicArtifact(com.github.ghik,silencer-plugin_2.12.18,1.7.13,null) [INFO] compiling 2 Scala sources and 1 Java source to /Users/nicholas/Github/celeborn/service/target/test-classes ... [ERROR] /Users/nicholas/Github/celeborn/service/src/test/scala/org/apache/celeborn/server/common/http/ApiBaseResourceSuite.scala:33: value readEntity is not a member of javax.ws.rs.core.Response [ERROR] /Users/nicholas/Github/celeborn/service/src/test/scala/org/apache/celeborn/server/common/http/ApiBaseResourceSuite.scala:77: value readEntity is not a member of javax.ws.rs.core.Response [ERROR] /Users/nicholas/Github/celeborn/service/src/test/scala/org/apache/celeborn/server/common/http/ApiBaseResourceSuite.scala:84: value readEntity is not a member of javax.ws.rs.core.Response [ERROR] /Users/nicholas/Github/celeborn/service/src/test/scala/org/apache/celeborn/server/common/http/ApiBaseResourceSuite.scala:91: value readEntity is not a member of javax.ws.rs.core.Response [ERROR] /Users/nicholas/Github/celeborn/service/src/test/scala/org/apache/celeborn/server/common/http/ApiBaseResourceSuite.scala:97: value readEntity is not a member of javax.ws.rs.core.Response ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual test. ``` $ mvn clean install -Dhadoop.version=2.10.0 -pl service -DskipTests -Dcheckstyle.skip=true -Drat.skip=true -Dspotless.check.skip=true [INFO] --- maven-install-plugin:2.5.2:install (default-install) celeborn-service_2.12 --- [INFO] Installing /Users/nicholas/Github/celeborn/service/target/celeborn-service_2.12-0.5.0-SNAPSHOT.jar to /Users/nicholas/.m2/repository/org/apache/celeborn/celeborn-service_2.12/0.5.0-SNAPSHOT/celeborn-service_2.12-0.5.0-SNAPSHOT.jar [INFO] Installing /Users/nicholas/Github/celeborn/service/.flattened-pom.xml to /Users/nicholas/.m2/repository/org/apache/celeborn/celeborn-service_2.12/0.5.0-SNAPSHOT/celeborn-service_2.12-0.5.0-SNAPSHOT.pom [INFO] Installing /Users/nicholas/Github/celeborn/service/target/celeborn-service_2.12-0.5.0-SNAPSHOT-tests.jar to /Users/nicholas/.m2/repository/org/apache/celeborn/celeborn-service_2.12/0.5.0-SNAPSHOT/celeborn-service_2.12-0.5.0-SNAPSHOT-tests.jar [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 13.928 s [INFO] Finished at: 2024-05-09T14:59:23+08:00 [INFO] ------------------------------------------------------------------------ ``` Closes #2497 from SteNicholas/CELEBORN-1006. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com> (cherry picked from commit a7862c9) Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Dependency
hadoop-clientshould excludehadoop-mapreduce-clientdependencies for Hadoop 2.Why are the changes needed?
hadoop-mapreduce-clientdependencies ofhadoop-clientare unneccessary. Meanwhile,hadoop-mapreduce-clientdependencies have dependencyjavax.servlet:javax.servlet-apiwhich causes the compilation error of service module after http server refine in 0.5.0 version.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual test.