Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1047] Remove conf celeborn.worker.sortPartition.eagerlyRemoveOriginalFiles.enabled #1999

Closed
wants to merge 1 commit into from

Conversation

cfmcgrady
Copy link
Contributor

What changes were proposed in this pull request?

As title

Why are the changes needed?

The config key celeborn.worker.sortPartition.eagerlyRemoveOriginalFiles.enabled has become unnecessary as a result of #1932

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GA

@cfmcgrady cfmcgrady requested a review from pan3793 October 18, 2023 07:05
Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1999 (4f71a6a) into main (6400071) will decrease coverage by 0.30%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1999      +/-   ##
==========================================
- Coverage   47.03%   46.73%   -0.30%     
==========================================
  Files         164      165       +1     
  Lines       10411    10532     +121     
  Branches      968      959       -9     
==========================================
+ Hits         4896     4921      +25     
- Misses       5196     5286      +90     
- Partials      319      325       +6     
Files Coverage Δ
...cala/org/apache/celeborn/common/CelebornConf.scala 87.69% <ø> (+0.11%) ⬆️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@waitinfuture waitinfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Merging to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants