Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASSANDRA-20343 CASSANDRA-20344 CASSANDRA-20345 CASSANDRA-20346 #3909

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

CASSANDRA-20343 CASSANDRA-20344 CASSANDRA-20345 CASSANDRA-20346 #3909

wants to merge 4 commits into from

Conversation

krummas
Copy link
Member

@krummas krummas commented Feb 18, 2025

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

Marcus Eriksson added 4 commits February 18, 2025 09:25
Allow empty placements when deserializing cluster metadata
1a3d6f3 
On upgrade we might have a cluster with an old bad schema, for example containing
NTS with references to datacenters that no longer exist - these replication strategies
will not have any placements at all - handle that by allowing empty placements.
Avoid adding LEFT nodes to tokenMap on upgrade from gossip
dfc6562 
If there are recently assassinated or decommissioned nodes left in gossip on upgrade
we should not add them to the token map - instead register them to look like normal
LEFT nodes.
Fix PartitionUpdate.isEmpty deserialization issue to avoid potential …
60ab08d 
…EOFException
nodetool cms unregister should also remove it from tokenMap if it is …
7c9eb16 
…there (incorrectly) and recalculate the placements
@krummas krummas requested a review from beobal February 18, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beobal beobal Awaiting requested review from beobal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krummas