CAMEL-18661: clean-ups

[bvahdat]

As follow-up with #8713

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

⚠️ Please note that the changes on this PR may be tested automatically.

If necessary Apache Camel Committers may access logs and test results in the job summaries!

[github-actions]

Components tested:

Total	Tested	Failed ❌	Passed ✅
3	3	1	2

[github-actions]

Components tested:

Total	Tested	Failed ❌	Passed ✅
3	3	0	3

[bvahdat]

Unfortunately we are dealing with a flaky test in CurrentSpanTest:

FE30905B2D30EEF-000000000000000A). Exhausted after delivery attempt: 1 caught: org.apache.camel.CamelExecutionException: Exception occurred during execution on the exchange: Exchange[]

Message History (source location and message history is disabled)
---------------------------------------------------------------------------------------------------------------------------------------
Source                                   ID                             Processor                                          Elapsed (ms)
                                         route46/route46                from[asyncmock3://start]                                2205581

Stacktrace
---------------------------------------------------------------------------------------------------------------------------------------
org.apache.camel.CamelExecutionException: Exception occurred during execution on the exchange: Exchange[]
	at org.apache.camel.CamelExecutionException.wrapCamelExecutionException(CamelExecutionException.java:45) ~[camel-api-3.20.0-SNAPSHOT.jar:3.20.0-SNAPSHOT]
	at org.apache.camel.support.AbstractExchange.setException(AbstractExchange.java:597) ~[camel-support-3.20.0-SNAPSHOT.jar:3.20.0-SNAPSHOT]
	at org.apache.camel.support.DefaultExchange.setException(DefaultExchange.java:27) ~[camel-support-3.20.0-SNAPSHOT.jar:3.20.0-SNAPSHOT]
	at org.apache.camel.support.processor.DelegateSyncProcessor.process(DelegateSyncProcessor.java:68) ~[camel-support-3.20.0-SNAPSHOT.jar:3.20.0-SNAPSHOT]
	at org.apache.camel.impl.engine.CamelInternalProcessor.process(CamelInternalProcessor.java:392) ~[camel-base-engine-3.20.0-SNAPSHOT.jar:3.20.0-SNAPSHOT]
	at org.apache.camel.processor.errorhandler.RedeliveryErrorHandler$SimpleTask.run(RedeliveryErrorHandler.java:477) ~[camel-core-processor-3.20.0-SNAPSHOT.jar:3.20.0-SNAPSHOT]
	at org.apache.camel.impl.engine.DefaultReactiveExecutor$Worker.schedule(DefaultReactiveExecutor.java:181) ~[camel-base-engine-3.20.0-SNAPSHOT.jar:3.20.0-SNAPSHOT]
	at org.apache.camel.impl.engine.DefaultReactiveExecutor.schedule(DefaultReactiveExecutor.java:54) ~[camel-base-engine-3.20.0-SNAPSHOT.jar:3.20.0-SNAPSHOT]
	at org.apache.camel.processor.MulticastProcessor.lambda$schedule$1(MulticastProcessor.java:336) ~[camel-core-processor-3.20.0-SNAPSHOT.jar:3.20.0-SNAPSHOT]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
	at java.lang.Thread.run(Thread.java:829) ~[?:?]
Caused by: org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) ~[junit-jupiter-api-5.9.1.jar:5.9.1]
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) ~[junit-jupiter-api-5.9.1.jar:5.9.1]
	at org.junit.jupiter.api.AssertFalse.failNotFalse(AssertFalse.java:63) ~[junit-jupiter-api-5.9.1.jar:5.9.1]
	at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:36) ~[junit-jupiter-api-5.9.1.jar:5.9.1]
	at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:31) ~[junit-jupiter-api-5.9.1.jar:5.9.1]
	at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:228) ~[junit-jupiter-api-5.9.1.jar:5.9.1]
	at org.apache.camel.opentelemetry.CurrentSpanTest$1.lambda$configure$1(CurrentSpanTest.java:232) ~[test-classes/:?]
	at org.apache.camel.support.processor.DelegateSyncProcessor.process(DelegateSyncProcessor.java:65) ~[camel-support-3.20.0-SNAPSHOT.jar:3.20.0-SNAPSHOT]
	... 10 more

The same behaviour has been also observed by #8713 where the a second run of the tests were successful without any code changes (with pipeline being manually triggered by @davsclaus):

Locally using JDK 11, 17, or 19 I am not able to reproduce the failure which happens at the following line:

https://github.com/apache/camel/blob/camel-3.20.0/components/camel-opentelemetry/src/test/java/org/apache/camel/opentelemetry/CurrentSpanTest.java#L231

I also did the same and now all tests are passing. So I'm gonne merge this PR today if no objections, as the issue is out of the scope of this PR and needs to be looked into separately.

[lmolkova]

@bvahdat thank you! I'll take a look at flaky test.

[bvahdat]

@bvahdat thank you! I'll take a look at flaky test.

Thanks @lmolkova for looking into this. So I merge this one now, feel free to provide a PR against the main branch.