Provide better instructions on the kit create command for missing nam… #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
approved these changes
Sep 10, 2019
oscerd
approved these changes
Sep 10, 2019
astefanutti
reviewed
Sep 10, 2019
pkg/cmd/kit_create.go
Outdated
| @@ -76,7 +75,7 @@ type kitCreateCommand struct { | |||
|
|
|||
| func (command *kitCreateCommand) validateArgs(_ *cobra.Command, args []string) error { | |||
| if len(args) != 1 { | |||
| return errors.New("accepts 1 arg, received " + strconv.Itoa(len(args))) | |||
| return errors.New("Create expects a single name argument.") | |||
There was a problem hiding this comment.
Error message should not start with capital letter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e param.
#586 refers to the kamel context create command, which looks to have been replaced by the kit command. This fix updates the language in the usage field to make the name arg requirement more clear.