fix(#3844): Add service discovery for Kamelet data type converter #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophd
force-pushed
the
issue/3844/data-type-service-discovery
branch
from
7be83bb to
5aa1055
Compare
squakez
reviewed
Dec 15, 2022
christophd
force-pushed
the
issue/3844/data-type-service-discovery
branch
4 times, most recently
from
9955b8c to
3c0a087
Compare
|
@squakez I have added some e2e YAKS test with Kamelets using the service discovery mechanism the failing |
squakez
requested changes
Dec 21, 2022
- Enable service discovery for data type converter resources in order to enable factory finder mechanism when resolving data type implementations - Add proper quarkus-maven-plugin build time properties for quarkus.camel.* properties - Fixes the way camel-quarkus build time properties are set (set properties on the quarkus-maven-plugin instead of using generic Maven system properties) - Explicitly add quarkus.camel.service.discovery.include-patterns for data type converter resources in order to enable lazy loading of Kamelets data type implementations Relates to apache#1980
- Kameletes used in the test make use of DataTypeRegistry and classpath scan is disabled - Data type registry will then perform a lookup of the data types via service discovery mechanism
christophd
force-pushed
the
issue/3844/data-type-service-discovery
branch
from
3c0a087 to
bda7d95
Compare
|
@squakez please have another look |
squakez
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1980
also see https://github.com/apache/camel-kamelets/tree/main/library/camel-kamelets-utils/src/main/resources/META-INF/services/org/apache/camel/datatype/converter
Fixes #3844