Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modeline for inspect. #1924

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Fix modeline for inspect. #1924

merged 2 commits into from
Jan 22, 2021

Conversation

doru1004
Copy link
Contributor

Enable modeline options for inspect command.

Release Note

Enable modeline support for inspect.

@doru1004 doru1004 mentioned this pull request Jan 20, 2021
Closed
apupier
apupier reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@apupier apupier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be useful to provide tests for the various additional use cases:

  • modeline-specified dependency added using mvn notation
  • modeline-specified dependency added using "simple" notation for a camel component
  • modeline-specified dependency added using jitpack notation
  • several modeline-specified dependencies written on several lines

@doru1004
Copy link
Contributor Author

I think it would be useful to provide tests for the various additional use cases:

  • modeline-specified dependency added using mvn notation
  • modeline-specified dependency added using "simple" notation for a camel component
  • modeline-specified dependency added using jitpack notation
  • several modeline-specified dependencies written on several lines

I have added some tests. The value of the dependency does not matter at this point. What we were missing for modeline is the addition of these dependencies when inspect was used.

@apupier
Copy link
Contributor

apupier commented Jan 21, 2021

any ideas why it is failing? https://github.com/apache/camel-k/pull/1924/checks?check_run_id=1735814158#step:9:2538

--- PASS: TestIntegrationUpgrade (71.05s)
FAIL
FAIL	github.com/apache/camel-k/e2e/common	1235.005s
FAIL
Error: Makefile:149: recipe for target 'test-integration' failed
make: *** [test-integration] Error 1
Error: Process completed with exit code 2.

https://github.com/apache/camel-k/pull/1924/checks?check_run_id=1735814158#step:9:2127

Error:     dump.go:147:     > 2021-01-20 16:29:32,520 ERROR [io.qua.run.Application] (main) Failed to start application (with profile prod): org.apache.camel.NoSuchEndpointException: No endpoint could be found for: cron://tab?schedule=0/1+*+*+*+*+?, please check your classpath contains the needed Camel component jar.

@astefanutti
Copy link
Member

@apupier there is a flaky e2e that fails from time to time, and that we need to investigate. I've relaunched the failing job.

@doru1004
Copy link
Contributor Author

@apupier I had a look at the error too but it doesn't look like it's related to this patch.

@astefanutti astefanutti merged commit 1217a6b into apache:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apupier apupier apupier left review comments

@astefanutti astefanutti astefanutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doru1004 @apupier @astefanutti