Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the option to set the camel version #1245

Merged
merged 5 commits into from
Feb 4, 2020
Merged

Remove the option to set the camel version #1245

merged 5 commits into from
Feb 4, 2020

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Jan 31, 2020 •
edited
Loading

Fixes #1229

Requires: apache/camel-k-runtime#231

Release Note

NONE

@lburgazzoli
Copy link
Contributor Author

lburgazzoli commented Jan 31, 2020 •
edited
Loading

@astefanutti @nicolaferraro still need to be polished and requires a new runtime release

astefanutti
astefanutti approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

nicolaferraro
nicolaferraro approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that Quarkus version is also included.

@lburgazzoli lburgazzoli force-pushed the github-1229 branch 2 times, most recently from 607101b to ae70207 Compare February 3, 2020 13:32
@lburgazzoli lburgazzoli marked this pull request as ready for review February 3, 2020 15:43
@nicolaferraro nicolaferraro merged commit 653228c into apache:master Feb 4, 2020
@lburgazzoli lburgazzoli deleted the github-1229 branch February 4, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@astefanutti astefanutti astefanutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the option to set the camel version
4 participants
@lburgazzoli @astefanutti @nicolaferraro @oscerd