Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kamel local build doesn't support same dependency notation #2213

Closed
apupier opened this issue Apr 13, 2021 · 2 comments · Fixed by #3444
Closed

kamel local build doesn't support same dependency notation #2213

apupier opened this issue Apr 13, 2021 · 2 comments · Fixed by #3444
Assignees
@tadayosi
Labels
area/cli Kamel CLI kind/bug Something isn't working status/never-stale
Milestone
1.10.0

Comments

@apupier
Copy link
Contributor

apupier commented Apr 13, 2021

kamel local build doesn't support same dependency notation which implies that some Cael k integration files are nto working in both context. it also implies that tooling cannot generate dependencies for all files.

for instance, using modeline // camel-k: dependency=camel-amqp is not working for kamel local build

error raised:

Error: Unexpected type for user-provided dependency: camel-http. Additional top-level dependencies are specified with the format:
<type>:<dependency-name>
where <type> is one of {bom|camel|camel-k|camel-quarkus|mvn|github}.

it is also revealing a difference with jitpack which is available as modeline when deploying not locally.
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 13, 2021
@apupier
WIP FUSETOOLS2-826 - add dependencies in classpath
a648c01 
provide command to add dependencies on classpath.
todo:
- continue to handle 1.3-
- report error of the command downloading dependencies
- rename or change flow to allow cleaning the internal folder
- wait for 1.4.0 release and remove the maven snapshot repository used

for next iterations:
- automatically call refresh
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 14, 2021
@apupier
WIP FUSETOOLS2-826 - add dependencies in classpath
cec11f2 
provide command to add dependencies on classpath.
todo:
- write test to handle 1.3-
- rename or change flow to allow cleaning the internal folder
- wait for 1.4.0 release and remove the maven snapshot repository used

for next iterations:
- automatically call refresh
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 15, 2021
@apupier
WIP FUSETOOLS2-826 - add dependencies in classpath
3265ce1 
provide command to add dependencies on classpath.
todo:
- wait for 1.4.0 release and remove the maven snapshot repository used

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh
- write test to handle 1.3- (or not and consider it as no more supported
and keep code for now as best-effort)

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Apr 15, 2021
Merged
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 15, 2021
@apupier
WIP FUSETOOLS2-826 - add dependencies in classpath
6a046b4 
provide command to add dependencies on classpath.
todo:
- wait for 1.4.0 release and remove the maven snapshot repository used

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh
- write test to handle 1.3- (or not and consider it as no more supported
and keep code for now as best-effort)

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 15, 2021
@apupier
WIP FUSETOOLS2-826 - add dependencies in classpath
02647fc 
provide command to add dependencies on classpath.
todo:
- wait for 1.4.0 release and remove the maven snapshot repository used

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh
- write test to handle 1.3- (or not and consider it as no more supported
and keep code for now as best-effort)

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 27, 2021
@apupier
WIP FUSETOOLS2-826 - add dependencies in classpath
5c0e6bc 
provide command to add dependencies on classpath.
todo:
- wait for 1.4.0 release and remove the maven snapshot repository used

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh
- write test to handle 1.3- (or not and consider it as no more supported
and keep code for now as best-effort)

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 27, 2021
@apupier
WIP FUSETOOLS2-826 - add dependencies in classpath
7f2ba50 
provide command to add dependencies on classpath.
todo:
- wait for 1.4.0 release and remove the maven snapshot repository used

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh
- write test to handle 1.3- (or not and consider it as no more supported
and keep code for now as best-effort)

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 27, 2021
@apupier
WIP FUSETOOLS2-826 - add dependencies in classpath
a63c82a 
provide command to add dependencies on classpath.
todo:
- wait for 1.4.0 release and remove the maven snapshot repository used

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh
- write test to handle 1.3- (or not and consider it as no more supported
and keep code for now as best-effort)

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 27, 2021
@apupier
WIP FUSETOOLS2-826 - add dependencies in classpath
9f3aae2 
provide command to add dependencies on classpath.
todo:
- wait for 1.4.0 release and remove the maven snapshot repository used

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh
- write test to handle 1.3- (or not and consider it as no more supported
and keep code for now as best-effort)

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874


Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 27, 2021
@apupier
FUSETOOLS2-826 - add dependencies in classpath
bf44218 
provide command to add dependencies on classpath.

no test to handle 1.3- as this use case is considered as best effort
only.

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 27, 2021
@apupier
FUSETOOLS2-826 - add dependencies in classpath
3a48a7f 
provide command to add dependencies on classpath.

no test to handle 1.3- as this use case is considered as best effort
only.

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 28, 2021
@apupier
FUSETOOLS2-826 - add dependencies in classpath
47f91db 
provide command to add dependencies on classpath.

no test to handle 1.3- as this use case is considered as best effort
only.

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 28, 2021
@apupier
FUSETOOLS2-826 - add dependencies in classpath
aab7015 
provide command to add dependencies on classpath.

no test to handle 1.3- as this use case is considered as best effort
only.

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/vscode-camelk that referenced this issue Apr 28, 2021
@apupier
FUSETOOLS2-826 - add dependencies in classpath
23f1935 
provide command to add dependencies on classpath.

no test to handle 1.3- as this use case is considered as best effort
only.

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to camel-tooling/vscode-camelk that referenced this issue Apr 29, 2021
@apupier
FUSETOOLS2-826 - add dependencies in classpath
74c6d11 
provide command to add dependencies on classpath.

no test to handle 1.3- as this use case is considered as best effort
only.

for next iterations:
- automatically call refresh when needed (to be determined when it is
needed)
- use a specific folder per file
- find a way to support two files opened at same time in different
window which are not sharing the same dependencies
- allow to configure parameters to provide to the call (like a maven
repository)
- provide progress report of refresh

limitations due to upstream:
- some notations not supported
apache/camel-k#2213
- a lot of place is taken in internal folders as jars are duplicated
instead of simply pointing to local .m2
apache/camel-k#2179
- use an API to refresh the classpath to avoid workaround of changing
back and forth the settings
redhat-developer/vscode-java#1874

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@apupier
Copy link
Contributor Author

apupier commented Oct 21, 2021

still very relevant

@tadayosi tadayosi self-assigned this May 27, 2022
@tadayosi tadayosi added this to the 1.10.0 milestone Jul 13, 2022
tadayosi added a commit to tadayosi/camel-k that referenced this issue Jul 13, 2022
@tadayosi
fix(cli): kamel local build doesn't support same dependency notation
cea0794 
This also fixes jitpack dependencies resolution.
Fix apache#2213.
@tadayosi tadayosi mentioned this issue Jul 13, 2022
Merged
@tadayosi tadayosi added kind/bug Something isn't working area/cli Kamel CLI labels Jul 13, 2022
tadayosi added a commit to tadayosi/camel-k that referenced this issue Jul 13, 2022
@tadayosi
fix(cli): kamel local build doesn't support same dependency notation
c5b05b1 
This also fixes jitpack dependencies resolution.
Fix apache#2213.
tadayosi added a commit that referenced this issue Jul 14, 2022
@tadayosi
fix(cli): kamel local build doesn't support same dependency notation
36439e1 
This also fixes jitpack dependencies resolution.
Fix #2213.
@tadayosi tadayosi mentioned this issue Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadayosi tadayosi

Labels
area/cli Kamel CLI kind/bug Something isn't working status/never-stale
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

fix(cli): kamel local build doesn't support same dependency notation tadayosi/camel-k
3 participants
@tadayosi @apupier @squakez