-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time it takes to build a kit in the builder pod log #1186
Comments
Ah you can see that as they are a build job and you can get the duration from k8s ❯ kubectl get builds -n mykamel |
the builds time is from the OpenShift s2i build so I guess it would be nice to report the time on the kits themselves so you know how long it took for a kit to be build regardless of the build engine used |
Note the Camel builds resources already report the build duration irrespective of the builder strategy. |
oh right, so I guess I can close my PR right ? |
or maybe not as builds may get evicted / pruned in the future |
Yes, I would be inclined not to duplicate the info into the kit CR. Even if builds get evicted, I think it's more a transient info w.r.t. to kits, and its value decreases long before the build would be evicted. |
let me close the PR then |
We can achieve this by:
Which returns something like:
|
When build a kit it takes many minutes. It would be good to have that logged so we can see how long it takes. The logs dont have timestamps. But we can add a log entry in the start.
Building kit XXX starting
Building kit XXX completed in 4m17s
The text was updated successfully, but these errors were encountered: