Fix #312: make linter happy

cmd/util/publisher/publisher.go

@@ -50,9 +50,8 @@ type PublisherOptions struct {
 
 // Publishes predefined images for all Camel components
 func main() {
+	options := PublisherOptions{}
 
-	options := PublisherOptions{
-	}
 	var cmd = cobra.Command{
 		Use:   "publisher",
 		Short: "Publisher allows to publish base images before a release",
@@ -162,6 +161,7 @@ func (options *PublisherOptions) build(component string, camelVersion string) er
 	}
 
 	archiveDir, archiveName := filepath.Split(ctx.Archive)
+	// nolint: gosec
 	dockerfile := `
 		FROM fabric8/s2i-java:2.3
 		ADD ` + archiveName + ` /deployments/

pkg/controller/integration/build_context.go

@@ -65,6 +65,9 @@ func (action *buildContextAction) Handle(ctx context.Context, integration *v1alp
 		}
 		if pl.Spec.Build.PredefinedImages {
 			ictx, err = ImportPredefinedContextIfPresent(ctx, action.client, integration)
+			if err != nil {
+				return err
+			}
 		}
 	}
 

pkg/platform/images/images_test.go

@@ -18,10 +18,11 @@ limitations under the License.
 package images
 
 import (
-	"github.com/apache/camel-k/version"
-	"github.com/stretchr/testify/assert"
 	"strconv"
 	"testing"
+
+	"github.com/apache/camel-k/version"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestImageLookup(t *testing.T) {
@@ -60,8 +61,9 @@ func TestImageLookup(t *testing.T) {
 	}
 
 	for i, tc := range cases {
+		testcase := tc
 		t.Run("case-"+strconv.Itoa(i), func(t *testing.T) {
-			assert.Equal(t, tc.image, LookupPredefinedImage(tc.dependencies))
+			assert.Equal(t, testcase.image, LookupPredefinedImage(testcase.dependencies))
 		})
 	}