Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Run tests in fedora 37 as well #1759

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

jjardon
Copy link
Contributor

@jjardon jjardon commented Sep 19, 2022

And remove soon to be deprecated fedora 35

Currently failing because python 3.11 is not supported: #1802

@ssssam
Copy link
Contributor

ssssam commented Sep 20, 2022

Looks to be failing due to missing longintrepr.h needed by pyroaring:

  pyroaring/pyroaring.cpp:220:12: fatal error: longintrepr.h: No such file or directory

This appears to be a bug in Cython which was already fixed last year: cython/cython#4461

Suggested fix would be to update the minimum Cython version 0.29.25

@juergbi
Copy link
Contributor

juergbi commented Dec 14, 2022

Suggested fix would be to update the minimum Cython version 0.29.25

This has been merged in the meantime as part of #1778.

@jjardon jjardon force-pushed the jjardon/master-f37 branch 3 times, most recently from 39efee2 to 620fe05 Compare December 14, 2022 19:31
@jjardon
Copy link
Contributor Author

jjardon commented Dec 14, 2022

Seems we still have he same problem: https://github.com/apache/buildstream/actions/runs/3698106262/jobs/6263904645

      pyroaring/pyroaring.cpp:220:12: fatal error: longintrepr.h: No such file or directory
        220 |   #include "longintrepr.h"
            |            ^~~~~~~~~~~~~~~

@cs-shadow
Copy link
Member

pyroraing should be fine after #1806 - we just had pinned an older release, newer versions are fine.

the next issue is with grpcio - see #1807 for how that fails. grpc/grpc#31960 should backport 3.11 support to the minor version we're on. However this also means that BuildStream (or at least its testsuite) doesn't work with grpicio versions 1.49 and above, which might be a problem in its own right.

@jjardon jjardon force-pushed the jjardon/master-f37 branch from b6b551a to 604c65c Compare January 2, 2023 18:28
@juergbi juergbi force-pushed the jjardon/master-f37 branch from 604c65c to 9d20161 Compare January 21, 2023 07:54
And remove soon to be deprecated fedora 35
@juergbi juergbi force-pushed the jjardon/master-f37 branch from 9d20161 to cc67e29 Compare January 21, 2023 11:03
@juergbi juergbi merged commit 33e8929 into apache:master Jan 21, 2023
@jjardon jjardon deleted the jjardon/master-f37 branch January 23, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants